chore: add markers in pom.xml#13353
Conversation
…tection, preventing them from being converted into broken tags
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds generator marker comments (such as {x-generated-dependencies-start}, {x-generated-proto-dependencies-start}, {x-generated-grpc-dependencies-start}, and {x-generated-modules-start}) to the pom.xml files across numerous Google Cloud Java client libraries. These markers delineate sections of generated dependencies and modules, likely to assist automated tools in updating them. There are no review comments on this pull request, and I have no feedback to provide.
|
|
|
hermetic build generation workflow failed on backstory, is expected. |
|
close as I don't want to manually resolve conflict. And will raise again when ready to turn done hermetic build. |
2 participants
Add comment markers in pom.xml for generated proto and grpc artifacts.
These markers are added in parent, BOM and client pom.xml files for each library.
Also included in this PR is a one line fix for sdk-platform-java/hermetic_build/library_generation/owlbot/src/fix_poms.py, so that it ignores comments during extra module detection, and does not produce broken pom.xml files when the original has comments.
The consequence of this minimal fix is that comments added will be wiped out when regenerated (see 557b1ed). This is acceptable as is only during migration and will re-run and add markers as needed.
For googleapis/librarian#6134