Skip to content

chore: sync librarian.yaml with generation_config.yaml#13347

Closed
zhumin8 wants to merge 3 commits into
googleapis:mainfrom
zhumin8:sync-librarian-0603
Closed

chore: sync librarian.yaml with generation_config.yaml#13347
zhumin8 wants to merge 3 commits into
googleapis:mainfrom
zhumin8:sync-librarian-0603

Conversation

@zhumin8

@zhumin8 zhumin8 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the backstory library to support both gRPC and HTTP/JSON transport layers, modifies the Go package options in the protobuf definitions, and adds the backstory library configuration to librarian.yaml. A Clirr configuration file was also introduced to ignore specific differences. However, in the clirr-ignored-differences.xml file, class names should be specified using dot separators instead of slash separators to ensure Clirr correctly identifies and ignores the differences.

@zhumin8

zhumin8 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Code changes in backstory:

  • some are due to proto change. Latest generation PR did not included these because it was created before backstory is added. So the main right now has backstory code generated from an earlier googeapis commitish and updated generated_config.yaml after.
    a90bc3d
  • java-backstory/proto-google-cloud-backstory/clirr-ignored-differences.xml file is created
  • repometadata and readme diff: defaults to both instead of grpc transport. But since this repo is proto only, there is no practical difference.

cc. @blakeli0

@zhumin8

zhumin8 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

generation diff found for bigtable, due to proto change:

diff --git a/google/bigtable/v2/bigtable.proto b/google/bigtable/v2/bigtable.proto
index 1a2bb37ccc..32c133bd9a 100644
--- a/google/bigtable/v2/bigtable.proto
+++ b/google/bigtable/v2/bigtable.proto
@@ -1187,6 +1187,15 @@ message ExecuteQueryRequest {
   // `Value.type` must match the corresponding `param_types` entry, or be
   // rejected with `INVALID_ARGUMENT`.
   map<string, Value> params = 7 [(google.api.field_behavior) = REQUIRED];
+
+  // Optional. This map provides the runtime values returned by the
+  // VIEW_PARAMETERS() function calls, typically used for user-level scoping of
+  // data based on identity.
+  //
+  // The key is the name of the view parameter e.g. `user_id`, and
+  // the value is the parameter value e.g. `alice@example.com`.
+  map<string, Value> view_parameters = 12
+      [(google.api.field_behavior) = OPTIONAL];
 }
 
 // Response message for Bigtable.ExecuteQuery
(END)

This is the only change git diff 0ff3c706a5e0964c6430529c406208f2ff57cf65 5481332007e57ad3d9cb81e83ff6bf9c449476b6
Root cause is last night's generation workflow only updated commitish but no code generation.
3ccc310#diff-70450badb57c93e27292190b5470ead474f3b2071e682e3d8274ec45e9510410L1
@blakeli0 is going to revert this change

@zhumin8

zhumin8 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

closing this one due to these changes:
#13350
#13351

@zhumin8 zhumin8 closed this Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant