test: test add and generate geminidataanalytics#13345
Closed
zhumin8 wants to merge 7 commits into
Closed
Conversation
…pis#13314)" This reverts commit 946dfb4.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the dependency configurations and modules for the Gemini Data Analytics library. However, due to a pathspec bug in the cleanup command used during the PR preparation, top-level files like generation_config.yaml and versions.txt were not properly restored to main. This resulted in the accidental removal of the v1 GAPIC configuration, missing version numbers in README.md, and an incorrect 0.0.0-SNAPSHOT version in Version.java. The feedback advises restoring these top-level files to correct the configuration and regenerate the code with the proper 0.21.0-SNAPSHOT version.
Contributor
Author
|
Generated diffs as expected. conclude this test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
steps taken:
git revert 946dfb4c66migrate ., manual keep librarian versionmigrate -insert-markers .go run github.com/googleapis/librarian/cmd/librarian@${V} add google/cloud/geminidataanalytics/v1go run github.com/googleapis/librarian/cmd/librarian@${V} generate geminidataanalyticsgit restore --source=main --staged --worktree ':(top)*/*' ':(top,exclude)java-geminidataanalytics/'For googleapis/librarian#6137