Skip to content

test: test add and generate geminidataanalytics#13345

Closed
zhumin8 wants to merge 7 commits into
googleapis:mainfrom
zhumin8:test-geminidataanalytics
Closed

test: test add and generate geminidataanalytics#13345
zhumin8 wants to merge 7 commits into
googleapis:mainfrom
zhumin8:test-geminidataanalytics

Conversation

@zhumin8

@zhumin8 zhumin8 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

steps taken:

  • revert recent code addition for API pathgit revert 946dfb4c66
  • sync librarian.yaml to condition prior to addition in 946dfb4: migrate ., manual keep librarian version
  • insert pom markers (this should be done separately, running here just to allow this test)migrate -insert-markers .
  • go run github.com/googleapis/librarian/cmd/librarian@${V} add google/cloud/geminidataanalytics/v1
  • go run github.com/googleapis/librarian/cmd/librarian@${V} generate geminidataanalytics
  • clean up irrelevant changes so this change is readablegit restore --source=main --staged --worktree ':(top)*/*' ':(top,exclude)java-geminidataanalytics/'

For googleapis/librarian#6137

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dependency configurations and modules for the Gemini Data Analytics library. However, due to a pathspec bug in the cleanup command used during the PR preparation, top-level files like generation_config.yaml and versions.txt were not properly restored to main. This resulted in the accidental removal of the v1 GAPIC configuration, missing version numbers in README.md, and an incorrect 0.0.0-SNAPSHOT version in Version.java. The feedback advises restoring these top-level files to correct the configuration and regenerate the code with the proper 0.21.0-SNAPSHOT version.

Comment thread generation_config.yaml
Comment thread versions.txt
@zhumin8

zhumin8 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Generated diffs as expected. conclude this test.

@zhumin8 zhumin8 closed this Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant