feat(storage): add checksum validation on json read paths#13269
Open
nidhiii-27 wants to merge 4 commits into
Open
feat(storage): add checksum validation on json read paths#13269nidhiii-27 wants to merge 4 commits into
nidhiii-27 wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces client-side CRC32C checksum validation for the HttpStorageRpc transport layer by adding the HttpStorageRpcHasherHelper utility class and integrating it into HttpStorageRpc. Feedback on the changes suggests removing leftover debugging System.out.println statements and simplifying an anonymous Supplier class to a lambda expression.
Dhriti07
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
nidhiii-27
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabled default full object checksum validation for the following:
Storage#readAllBytes(bucket,blob)Storage.downloadTo(blobId, destination)Storage.downloadTo(blob, outputStream)