Skip to content

test: StreamWriterTest to allow version in trace ID #12084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suztomo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: StreamWriterTest to allow version in trace ID #12084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/StreamWriterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,10 @@ private void verifyAppendRequests(long appendCount) {
// First request received by server should have schema and stream name.
assertTrue(serverRequest.getProtoRows().hasWriterSchema());
assertEquals(TEST_STREAM_1, serverRequest.getWriteStream());
assertEquals("java-streamwriter " + TEST_TRACE_ID, serverRequest.getTraceId());
// The trace ID would look like "java-streamwriter:3.23.0 DATAFLOW:job_id" if
// StreamWriter.getFullTraceId contains the version (non SNAPSHOT version);
// otherwise it's "java-streamwriter DATAFLOW:job_id".
assertThat(serverRequest.getTraceId()).matches("java-streamwriter(:.+)? " + TEST_TRACE_ID);
} else {
// Following request should not have schema and stream name.
assertFalse(serverRequest.getProtoRows().hasWriterSchema());
Expand Down
Loading