chore: refactor all opentelemetry span logic for RPC calls into generic executeWithSpan function#12066
Closed
ldetmer wants to merge 3 commits intomain-backupfrom
Closed
chore: refactor all opentelemetry span logic for RPC calls into generic executeWithSpan function#12066ldetmer wants to merge 3 commits intomain-backupfrom
ldetmer wants to merge 3 commits intomain-backupfrom
Conversation
ldetmer
changed the title
jinseopkim0
reviewed
Mar 13, 2026
| try (Scope scope = span.makeCurrent()) { | ||
| return operation.execute(span); | ||
| } finally { | ||
| span.end(); |
Contributor
There was a problem hiding this comment.
Would it be possible to add a test for an RPC failure to verify this behavior?
ldetmer
added a commit
that referenced
this pull request
Mar 13, 2026
Add full unit test coverage for HttpBigQueryRpc for easy validation of refactor changes for the observability project [see fast follow PR](#12066).
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 13, 2026
Add full unit test coverage for HttpBigQueryRpc for easy validation of refactor changes for the observability project [see fast follow PR](googleapis#12066).
Member
|
We had to rewrite the history of this repository (See "SDK Java" chat for details). The pending pull requests require some actions:
|
Contributor
Author
|
i had too many conflicts will open new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to setup the ability to add new attributes to existing tracing span for the observability project. This is no-op functional change for the current code, but achieves the following:
Example trace before change
Example trace after change