Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/checkers.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@ RUN pip3 install mdformat==0.7.19 \
mdformat-frontmatter==2.0.8 \
mdformat-footnote==0.1.1

RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.28.1/bazelisk-linux-${ARCH}" && \
RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.29.0/bazelisk-linux-${ARCH}" && \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid duplicating the version string across multiple Dockerfiles, define the Bazelisk version using an ARG instruction.

ARG BAZELISK_VERSION=1.29.0
RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v${BAZELISK_VERSION}/bazelisk-linux-${ARCH}" && \\
References
  1. In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.

chmod +x /usr/bin/bazelisk && \
ln -s /usr/bin/bazelisk /usr/bin/bazel
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/fedora-latest-bazel.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ RUN /var/tmp/ci/install-cloud-sdk.sh
ENV CLOUD_SDK_LOCATION=/usr/local/google-cloud-sdk
ENV PATH=${CLOUD_SDK_LOCATION}/bin:${PATH}

RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.28.1/bazelisk-linux-${ARCH}" && \
RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.29.0/bazelisk-linux-${ARCH}" && \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid duplicating the version string across multiple Dockerfiles, define the Bazelisk version using an ARG instruction.

ARG BAZELISK_VERSION=1.29.0
RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v${BAZELISK_VERSION}/bazelisk-linux-${ARCH}" && \\
References
  1. In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.

chmod +x /usr/bin/bazelisk && \
ln -s /usr/bin/bazelisk /usr/bin/bazel

Expand Down
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/fedora-msan.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,6 @@ RUN /var/tmp/ci/install-cloud-sdk.sh
ENV CLOUD_SDK_LOCATION=/usr/local/google-cloud-sdk
ENV PATH=${CLOUD_SDK_LOCATION}/bin:${PATH}

RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.28.1/bazelisk-linux-${ARCH}" && \
RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.29.0/bazelisk-linux-${ARCH}" && \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid duplicating the version string across multiple Dockerfiles, define the Bazelisk version using an ARG instruction.

ARG BAZELISK_VERSION=1.29.0
RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v${BAZELISK_VERSION}/bazelisk-linux-${ARCH}" && \\
References
  1. In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.

chmod +x /usr/bin/bazelisk && \
ln -s /usr/bin/bazelisk /usr/bin/bazel
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/ubuntu-22.04.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,6 @@ RUN /var/tmp/ci/install-cloud-sdk.sh
ENV CLOUD_SDK_LOCATION=/usr/local/google-cloud-sdk
ENV PATH=${CLOUD_SDK_LOCATION}/bin:${PATH}

RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.28.1/bazelisk-linux-${ARCH}" && \
RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.29.0/bazelisk-linux-${ARCH}" && \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid duplicating the version string across multiple Dockerfiles, define the Bazelisk version using an ARG instruction.

ARG BAZELISK_VERSION=1.29.0
RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v${BAZELISK_VERSION}/bazelisk-linux-${ARCH}" && \\
References
  1. In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.

chmod +x /usr/bin/bazelisk && \
ln -s /usr/bin/bazelisk /usr/bin/bazel
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/ubuntu-24.04.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,6 @@ RUN /var/tmp/ci/install-cloud-sdk.sh
ENV CLOUD_SDK_LOCATION=/usr/local/google-cloud-sdk
ENV PATH=${CLOUD_SDK_LOCATION}/bin:${PATH}

RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.28.1/bazelisk-linux-${ARCH}" && \
RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.29.0/bazelisk-linux-${ARCH}" && \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid duplicating the version string across multiple Dockerfiles, define the Bazelisk version using an ARG instruction.

ARG BAZELISK_VERSION=1.29.0
RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v${BAZELISK_VERSION}/bazelisk-linux-${ARCH}" && \\
References
  1. In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.

chmod +x /usr/bin/bazelisk && \
ln -s /usr/bin/bazelisk /usr/bin/bazel
Loading