Skip to content

impl(bigtable): add snippet demonstrating query execution#15753

Merged
scotthart merged 5 commits intogoogleapis:mainfrom
scotthart:bigtable_query_snippet_2
Nov 15, 2025
Merged

impl(bigtable): add snippet demonstrating query execution#15753
scotthart merged 5 commits intogoogleapis:mainfrom
scotthart:bigtable_query_snippet_2

Conversation

@scotthart
Copy link
Copy Markdown
Member

No description provided.

@scotthart scotthart requested a review from a team November 12, 2025 21:40
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Nov 12, 2025
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Bigtable C++ client library examples by introducing a comprehensive demonstration of SQL query execution. It refactors the example command handling to better support client-centric operations and integrates the new query example into the automated example suite and as a standalone command-line option, improving clarity and usability for developers learning to interact with Bigtable via SQL.

Highlights

  • New Query Execution Example: A new example, PrepareAndExecuteQuery, has been added to demonstrate how to prepare and execute SQL queries against Bigtable using the C++ client library, including parameter binding and result processing.
  • Example Infrastructure Enhancement: The example command infrastructure has been extended with a new MakeCommandEntry overload and ClientCommandType to simplify the creation of example commands that operate directly on a google::cloud::bigtable::Client object.
  • Doxygen Snippet Integration: The google/cloud/bigtable/client.h header now uses a Doxygen @snippet directive to reference the new query execution example, keeping the header documentation concise and up-to-date with external examples.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

diegomarquezp
diegomarquezp previously approved these changes Nov 12, 2025
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new code snippet demonstrating how to execute a query with the Bigtable C++ client. The changes are generally good, but I've found a couple of issues that prevent the new example from running correctly. One is a critical bug where the example code is not actually called, and another is a misconfiguration in the command-line argument parsing. Please see my detailed comments.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 34.14634% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.94%. Comparing base (6d79425) to head (05dac5f).

Files with missing lines Patch % Lines
google/cloud/bigtable/examples/data_snippets.cc 7.69% 24 Missing ⚠️
...loud/bigtable/examples/bigtable_examples_common.cc 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15753      +/-   ##
==========================================
- Coverage   92.95%   92.94%   -0.01%     
==========================================
  Files        2448     2448              
  Lines      226391   226434      +43     
==========================================
+ Hits       210442   210464      +22     
- Misses      15949    15970      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart enabled auto-merge (squash) November 13, 2025 16:59
@scotthart scotthart disabled auto-merge November 15, 2025 00:32
@scotthart scotthart enabled auto-merge (squash) November 15, 2025 00:32
@scotthart scotthart merged commit 659a261 into googleapis:main Nov 15, 2025
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants