impl(bigtable): add snippet demonstrating query execution#15753
impl(bigtable): add snippet demonstrating query execution#15753scotthart merged 5 commits intogoogleapis:mainfrom
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Bigtable C++ client library examples by introducing a comprehensive demonstration of SQL query execution. It refactors the example command handling to better support client-centric operations and integrates the new query example into the automated example suite and as a standalone command-line option, improving clarity and usability for developers learning to interact with Bigtable via SQL. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a new code snippet demonstrating how to execute a query with the Bigtable C++ client. The changes are generally good, but I've found a couple of issues that prevent the new example from running correctly. One is a critical bug where the example code is not actually called, and another is a misconfiguration in the command-line argument parsing. Please see my detailed comments.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15753 +/- ##
==========================================
- Coverage 92.95% 92.94% -0.01%
==========================================
Files 2448 2448
Lines 226391 226434 +43
==========================================
+ Hits 210442 210464 +22
- Misses 15949 15970 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8983649 to
89e8a75
Compare
No description provided.