Skip to content

chore(format): Update formatter to handle plus signs in emails with Google domains #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lindsey-volta merged 2 commits into from
Jun 2, 2026
Merged

chore(format): Update formatter to handle plus signs in emails with Google domains #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c7489a
Update formatter to handle plus signs in emails with Google domains
lindsey-volta Jun 2, 2026
f1adc91
Bump util version to 0.2.0
lindsey-volta Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Google.Ads.DataManager.Util/src/Google.Ads.DataManager.Util.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<PackageId>Google.Ads.DataManager.Util</PackageId>
<Version>0.1.0</Version>
<Version>0.2.0</Version>
<Authors>Google</Authors>
<Description>A library to help with common tasks for the Google Ads Data Manager API.</Description>
<PackageTags>Google Ads Data Manager API</PackageTags>
Expand Down
1 change: 1 addition & 0 deletions Google.Ads.DataManager.Util/src/UserDataFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ public string FormatEmailAddress(string emailAddress)

if (domain == "gmail.com" || domain == "googlemail.com")
{
username = username.Split('+')[0];
Comment thread
lindsey-volta marked this conversation as resolved.
username = PeriodPattern.Replace(username, "");
}

Expand Down
12 changes: 12 additions & 0 deletions Google.Ads.DataManager.Util/tests/UserDataFormatterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ public void TestFormatEmailAddress_ValidInputs()
_formatter.FormatEmailAddress("QuinnY@EXAMPLE.com"),
Is.EqualTo("quinny@example.com")
);
Assert.That(
_formatter.FormatEmailAddress("user.name+NYC@Example.com"),
Is.EqualTo("user.name+nyc@example.com")
);
}

[Test]
Expand Down Expand Up @@ -61,6 +65,14 @@ public void TestFormatEmailAddress_GmailVariations()
_formatter.FormatEmailAddress("j.e.f..ferson.Loves.hiking@googlemail.com"),
Is.EqualTo("jeffersonloveshiking@googlemail.com")
);
Assert.That(
_formatter.FormatEmailAddress("Cloudy.SanFrancisco+shopping@gmail.com"),
Is.EqualTo("cloudysanfrancisco@gmail.com")
);
Assert.That(
_formatter.FormatEmailAddress("Cloudy.SanFrancisco+shopping@googlemail.com"),
Is.EqualTo("cloudysanfrancisco@googlemail.com")
);
}

[Test]
Expand Down