Open
Conversation
Collaborator
antongolub
commented
Aug 11, 2025
- Tests pass
- Appropriate changes to README are included in PR
Collaborator
|
Why this change? |
Collaborator
Author
|
Aligns overload implementations across the code: replaces args mutations with a recursive call. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the cd() function to avoid mutating the input argument by using recursion instead of reassignment when handling ProcessOutput instances.
- Replaces argument mutation with recursive call pattern
- Adds explicit
voidreturn type annotation to the TypeScript version
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/core.ts | Refactors cd() to use recursion instead of mutating the dir parameter |
| build/core.cjs | Compiled JavaScript output reflecting the same refactoring changes |
Comment on lines
+1030
to
1033
| if (dir instanceof ProcessOutput) return cd(dir.toString().trim()) | ||
|
|
||
| $.log({ kind: 'cd', dir, verbose: !$.quiet && $.verbose }) | ||
| process.chdir(dir) |
There was a problem hiding this comment.
The recursive call creates unnecessary function call overhead. Consider using a local variable assignment instead: const dirStr = dir instanceof ProcessOutput ? dir.toString().trim() : dir; then proceed with the rest of the function using dirStr.
Suggested change
| if (dir instanceof ProcessOutput) return cd(dir.toString().trim()) | |
| $.log({ kind: 'cd', dir, verbose: !$.quiet && $.verbose }) | |
| process.chdir(dir) | |
| const dirStr = dir instanceof ProcessOutput ? dir.toString().trim() : dir; | |
| $.log({ kind: 'cd', dir: dirStr, verbose: !$.quiet && $.verbose }) | |
| process.chdir(dirStr) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.