Skip to content

Conversation

@ProbstDJakob
Copy link
Contributor

@ProbstDJakob ProbstDJakob commented Jan 14, 2026

This pull request fixes a problem with the current way to find the config. Currently the config will be searched up to the root but excluding it, even if the working directory is the root. This means a file at /yamlfmt.yaml will never be considered as config file. This is especially noticeable in container images where the working directory is either not known during the build of the image (in which the config will be added) or the config should only be a fallback in case the mounted working directory itself does not contain one. Using the $XDG_CONFIG_HOME wouldn't be a suitable solution, as the container may not be run as the user it has been configured with during the build of the image.

@google-cla
Copy link

google-cla bot commented Jan 14, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ProbstDJakob
Copy link
Contributor Author

The CLA should be available now.

@braydonk
Copy link
Collaborator

Please add a description to the PR that explains what this is fixing.

@ProbstDJakob
Copy link
Contributor Author

Done

@braydonk
Copy link
Collaborator

Sorry, it looks like the CLA is still not working for some reason. There's troubleshooting steps in the invocation to help determine why it's still not working: https://github.com/google/yamlfmt/pull/312/checks?check_run_id=60405691271

@ProbstDJakob
Copy link
Contributor Author

I've double checked the CLA, but I can not see why it should not work. The GitHub username has been made lowercase within the CLA, but besides that it matches and the E-Mail used to commit is also contained within the CLA.

If this does for what ever reason not work, I am completely fine if someone copies the five lines and opens a new PR with a valid CLA. There is absolutely nothing special about that lines and I do not need attribution for it.

@ProbstDJakob
Copy link
Contributor Author

Can anyone with a working CLA create a new PR?

@ProbstDJakob
Copy link
Contributor Author

Never mind, I've overlooked the sentence stating to rescan for CLAs which provides a link.

@braydonk
Copy link
Collaborator

Oh great it's working now. Sorry that the comment from two weeks ago slipped past me, I could have made the patch sooner. (managing everything through GitHub notifications instead of email is having some growing pains)

Thank you for the patch!

@braydonk braydonk merged commit da6a3e2 into google:main Jan 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants