Migrate xls::down_cast to use absl::down_cast.#3797
Merged
copybara-service[bot] merged 1 commit intomainfrom Feb 7, 2026
Merged
Migrate xls::down_cast to use absl::down_cast.#3797copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_865507991
branch
5 times, most recently
from
ce93c92 to
3758d62
Compare
The xls::down_cast functions are now implemented as direct calls to absl::down_cast and are marked with ABSL_DEPRECATE_AND_INLINE. Note that we also bump our abseil dep to grab a newer version with absl::down_cast. PiperOrigin-RevId: 866676858
copybara-service
bot
force-pushed
the
test_865507991
branch
from
3758d62 to
8ee59ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate xls::down_cast to use absl::down_cast.
The xls::down_cast functions are now implemented as direct calls to absl::down_cast and are marked with ABSL_DEPRECATE_AND_INLINE.
Note that we also bump our abseil dep to grab a newer version with absl::down_cast.