This repository was archived by the owner on Aug 25, 2025. It is now read-only.
all: update the x/tools dependency to fix the build with Go 1.25#432
Merged
findleyr merged 1 commit intogoogle:mainfrom Aug 21, 2025
Merged
all: update the x/tools dependency to fix the build with Go 1.25#432findleyr merged 1 commit intogoogle:mainfrom
findleyr merged 1 commit intogoogle:mainfrom
Conversation
findleyr
force-pushed
the
fixbuild
branch
2 times, most recently
from
be25772 to
0b783bc
Compare
An unfortunate bug caused a number of packages in old x/tools versions to fail to build with Go 1.25 (https://go.dev/issue/74462). Fix this minimally by updating to the lowest patched version with the fix: v0.24.1. This should allow wire to continue building with the same range of Go versions as it could build with before (down to 1.19). Also: - Update the go.mod go directive to Go 1.19 to allow for module graph pruning, and to be consistent with the minimum build version. - Fix a test that is broken in recent Go versions due to an error message change. - Update tests to run on Go 1.25.x (the most recent version of Go). - Remove coverage, since coverage upload wasn't working anyway. Fixes google#431
tbxark
added a commit
to wireinject/wire
that referenced
this pull request
Aug 21, 2025
tbxark
added a commit
to wireinject/wire
that referenced
this pull request
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unfortunate bug caused a number of packages in old x/tools versions to fail to build with Go 1.25 (https://go.dev/issue/74462). Fix this minimally by updating to the lowest patched version with the fix: v0.24.1. This should allow wire to continue building with the same range of Go versions as it could build with before (down to 1.19).
Also:
Fixes #431