Skip to content

Conversation

@ia0
Copy link
Member

@ia0 ia0 commented Jan 23, 2026

No description provided.

@ia0 ia0 added the for:maintainability Improves maintainers life label Jan 23, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the CI sharding for tests and hardware-in-the-loop checks, which should help improve CI performance. The sharding logic has been refactored into a new scripts/shard.sh script, which is a great improvement for maintainability. My review includes a few suggestions to improve the clarity of the new sharding script and to use GitHub Actions expression functions for a cleaner implementation in the workflow file.

@ia0 ia0 merged commit 899cc36 into google:main Jan 23, 2026
31 checks passed
@ia0 ia0 deleted the shard branch January 23, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

for:maintainability Improves maintainers life

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants