Fix visibility of host functions for protocol#1021
Merged
ia0 merged 2 commits intogoogle:mainfrom Jan 23, 2026
Merged
Conversation
ia0
added
for:usability
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly restricts the visibility of several host-specific functions and types in the wasefire-protocol crate to the host feature. The changes are consistent and well-implemented. I've only found a minor omission in the CHANGELOG.md file, where not all the restricted items are mentioned. I've left a suggestion to make the changelog more complete. Overall, this is a good improvement for code modularity.
ia0-review
previously approved these changes
Jan 23, 2026
ia0-review
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.