Validate tar members before archive extraction#1628
Open
SylvainWinning wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
aarontp
reviewed
May 27, 2026
Member
aarontp
left a comment
There was a problem hiding this comment.
First pass look looks good, thanks! Letting the tests run and will look closer for final review after that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validate tar archive members before extracting compressed directory evidence. The new validation rejects members that would write outside the generated extraction directory, including parent-directory paths, absolute paths, and link targets that escape the extraction root.
This keeps valid archives working while failing closed on unsafe archive entries.
Tests
python3 -m unittest turbinia.processors.archive_testTurbiniaExceptionbefore extraction