Skip to content

Validate tar members before archive extraction#1628

Open
SylvainWinning wants to merge 1 commit into
google:masterfrom
SylvainWinning:codex/safe-tar-extraction
Open

Validate tar members before archive extraction#1628
SylvainWinning wants to merge 1 commit into
google:masterfrom
SylvainWinning:codex/safe-tar-extraction

Conversation

@SylvainWinning
Copy link
Copy Markdown

Description

Validate tar archive members before extracting compressed directory evidence. The new validation rejects members that would write outside the generated extraction directory, including parent-directory paths, absolute paths, and link targets that escape the extraction root.

This keeps valid archives working while failing closed on unsafe archive entries.

Tests

  • python3 -m unittest turbinia.processors.archive_test
  • Local path traversal PoC now raises TurbiniaException before extraction

@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 22, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Copy Markdown
Member

@aarontp aarontp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass look looks good, thanks! Letting the tests run and will look closer for final review after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants