Improvement of Request ID and Other#1587
Open
HolzmanoLagrene wants to merge 4 commits intogoogle:masterfrom
Open
Improvement of Request ID and Other#1587HolzmanoLagrene wants to merge 4 commits intogoogle:masterfrom
HolzmanoLagrene wants to merge 4 commits intogoogle:masterfrom
Conversation
…Path_Style_Request_IDS Change Signature of Request Endpoints
Fix File Name Creation for proper handling of multiple suffixes
aarontp
reviewed
Apr 30, 2025
Member
aarontp
left a comment
aarontp
left a comment
There was a problem hiding this comment.
Hi @HolzmanoLagrene : The evidence.py changes LGTM, but I have some questions about the other path related change so I added a comment to #1585
Member
|
Sorry for not getting back to this earlier. I think we need to have a slightly different fix for the upload path issue, and I'll try to come up with a proposal for that. If you want to pull out the router.get() changes we can get the other fix submitted first though. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Introduces a way to use paths as request_ids without breaking the current behaviour!
Also fixes Fix the problem of multiple suffixes not being added to the file name.
Applicable issues
#1586
#1585
Additional information
It seems half of the checks fail, but its not related to any of my changes. Also
Checklist