This repository was archived by the owner on Nov 30, 2023. It is now read-only.
[python3] Import six, fix urllib, stringio and dircache errors #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avilaton
changed the title
Contributor
Author
|
I added fixes for StringIO and dircache issues. |
Contributor
|
Adding six as a new dependency requires a new release, since it is a breaking change (a user update will cause breakage). Since I've already merged the StringIO and dircache parts, can you rework the urllib part to use compat.py file? That would be much simpler to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, happy father's day in argentina. There was a country wire power outage over here, I used some of the time to hack in this project to move to python3.
Since the first complains from travis on python3 are about urllib2 not existing on python3, I worked first on that. I imported six because we are all grown ups now and I think adding it should be ok with everyone. At least I hope it is.