Skip to content
This repository was archived by the owner on Jan 8, 2024. It is now read-only.

Conversation

@smit-hinsu
Copy link

Tested with ./run_tests.sh

@smit-hinsu
Copy link
Author

@davidstanke Please take a look.

Copy link
Contributor

@duggelz duggelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However, I can't merge this, since I no longer work for Google.

@davidstanke
Copy link

Hey! I'm not comfortable merging this -- I'm not engaged on implementation of Bazel/Python features. So I'll pass to @brandjon, who is.

@smit-hinsu
Copy link
Author

Thanks @davidstanke for adding Jon on the PR.

@brandjon
Copy link
Contributor

I'm not familiar with subpar's implementation details, but the change looks simple enough, and Douglas already signed off on it.

@brandjon
Copy link
Contributor

Hm, actually I don't appear to have merge rights in this repo. Not sure who does. I'll look into that...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants