feat(local): support including and excluding malware advisories#2449
Closed
G-Rath wants to merge 2 commits intogoogle:mainfrom
Closed
feat(local): support including and excluding malware advisories#2449G-Rath wants to merge 2 commits intogoogle:mainfrom
G-Rath wants to merge 2 commits intogoogle:mainfrom
Conversation
G-Rath
force-pushed
the
perf/skip-malware
branch
2 times, most recently
from
adf55e6 to
76be85d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2449 +/- ##
==========================================
- Coverage 67.79% 66.45% -1.35%
==========================================
Files 172 172
Lines 13301 13326 +25
==========================================
- Hits 9018 8856 -162
- Misses 3573 3687 +114
- Partials 710 783 +73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
G-Rath
force-pushed
the
perf/skip-malware
branch
from
76be85d to
5de8899
Compare
Collaborator
Author
|
I'm not sure this is that useful now that #2450 has been landed as the cost of our automatic method of doing this has been decreased a great amount... |
|
This pull request has not had any activity for 60 days and will be automatically closed in two weeks |
github-actions
Bot
added
the
stale
Collaborator
Author
|
yeah this hopefully isn't needed anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an experimental flag for controlling how malware advisories (
MAL-) are loaded as these advisories are very easy to create and are very common in some ecosystems e.g. of the 214057 advisories in the NPM database, only 4410 are actual vulnerabilities - the remaining 209647 are MAL.Skipping these advisories entirely can greatly reduce the time taken and memory used when doing offline scans