fix(rust): disable unsafe cargo build by default to prevent ACE#2409
Closed
GHOryy5 wants to merge 2 commits intogoogle:mainfrom
Closed
fix(rust): disable unsafe cargo build by default to prevent ACE#2409GHOryy5 wants to merge 2 commits intogoogle:mainfrom
GHOryy5 wants to merge 2 commits intogoogle:mainfrom
Conversation
Collaborator
|
Thanks for the contribution! Rust call analysis is not enabled by default, and has to be manually enabled, so I'm not sure adding an extra env makes sense. It is also made clear that it's building the project to do call analysis, so it's up to the user to not run malicious build scripts. Perhaps a change to the --help message would be more appropriate here? E.g. update |
another-rex
added a commit
that referenced
this pull request
Jan 21, 2026
This change updates the documentation and help output to clarify that Rust call analysis runs build scripts. It adds a warning to the documentation and enhances the help text to make this behavior more explicit to users. Closes #2409 --- *PR created automatically by Jules for task [7523658291025527036](https://jules.google.com/task/7523658291025527036) started by @another-rex* --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Joey L <joeylauy@google.com> Co-authored-by: Rex P <106129829+another-rex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mitigates a Critical Arbitrary Code Execution (ACE) vulnerability in the Rust source analysis pipeline.
The Vulnerability
Currently,
rustBuildSourceexecutescargo buildon the target repository. In the Rust ecosystem,cargo buildexecutesbuild.rsscripts and procedural macros. Ifosv-scanneris run on an untrusted malicious repository, that repository can execute arbitrary code on the scanner's host.