-
Notifications
You must be signed in to change notification settings - Fork 172
allow building ml_metadata_store_server image on ARM64
#188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
allow building ml_metadata_store_server image on ARM64
#188
Conversation
|
@zijianjoy @chensun you might be interested in this, as I am not 100% confident in this PR, so would appreciate testing/review from your end. |
|
For those who want to test, I have made a forked repo in the deployKF org with the ARM versions of the Note, building under emulation on GitHub actions took about 5 hours: |
|
@XinranTang @ml-metadata-team @tarilabs just wondering if I should rebase this (since the bazel 6.1.0 update created merge conflicts) so we can get this building for ARM merged? |
5f3a351 to
58aa796
Compare
|
I rebased it. Note, this only fixes the building of |


This PR updates the Dockerfile and other things to allow the
gcr.io/tfx-oss-public/ml_metadata_store_serverto be built for alinux/arm64target.This is important for Kubeflow Pipelines, and thus deployKF (a tool for deploying Kubeflow).
The changes are:
ml_metadata/tools/docker_server/Dockerfileto use Bazelisk (this was the easiest way to download the ARM64 version of Bazel 5.3.0).bazelversionin the repo root (Bazelisk expects it to be there)./ml_metadata/.bazelversion(this breaks Bazelisk)ml_metadata/postgresql.BUILDdirectly the same as upstreamtensorflow/iocommita1171cdd20e658ef3f1a8b3bf66dd4e228ceae30(to remove X86-specific stuff)Next Steps:
ml_metadata/postgresql.BUILDdid not cause a regression.amd64ANDarm64versions ofgcr.io/tfx-oss-public/ml_metadata_store_server