Skip to content

Swaps append for concat for data frame in default_geo_assignment #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cimentadaj wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Swaps append for concat for data frame in default_geo_assignment #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions matched_markets/methodology/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,13 +256,11 @@ def default_geo_assignment(geo_level_time_series: pd.DataFrame,
missing_geos = list(
set(geo_level_time_series['geo']) - set(geo_eligibility['geo']))

return geo_eligibility.append(
pd.DataFrame({
'geo': missing_geos,
'control': 1,
'treatment': 1,
'exclude': 1
})).sort_values(by='geo').reset_index(drop=True)
missing_df = pd.DataFrame({'geo': missing_geos, 'control': 1, 'treatment': 1, 'exclude': 1})

df = pd.concat([geo_eligibility, missing_df]).sort_values(by="geo").reset_index(drop = True)
return df



def plot_iroas_over_time(iroas_df: pd.DataFrame, experiment_dates: pd.DataFrame,
Expand Down