Skip to content

Conversation

@silvio2402
Copy link
Contributor

@silvio2402 silvio2402 commented Jan 10, 2025

  • Refactor the logic to extract the phone context from an RFC3966 URI to a new PhoneContextParser class.
  • Refactor the number normalization methods normalizeDigits and normalizeDigitsOnly to a new PhoneNumberNormalizer class.

    This keeps PhoneNumberUtil.normalizeDigitsOnly as a shell because it is public.

  • Move the constants that are common between PhoneContextParser and PhoneNumberUtil to a new Constants class.

This is a refactor and should not change the logic of the parser.

Context: b/370922064

@silvio2402 silvio2402 requested a review from tvislavski January 10, 2025 16:53
@silvio2402 silvio2402 requested a review from a team as a code owner January 10, 2025 16:53
@silvio2402
Copy link
Contributor Author

Refer to new PR: #3791

@silvio2402 silvio2402 closed this Jan 22, 2025
@silvio2402 silvio2402 deleted the phonecontextparser-java branch January 29, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant