agent: ignore timeouts in list pending requests #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the agent tries to list pending requests and there are no requests to return, there are two possible behaviors: 1. The proxy stops waiting first and returns an empty list of request IDs. 2. The agent stops waiting first and returns a timeout error. For both of these scenarios, the right next steps are the same; the proxy agent should just keep polling for pending requests. However, previously these were handled differently; in the first case the agent would poll again immediately, whereas the second it would log an error message and then use backoff logic to decide how long to wait until polling again. This *could* be handled by simply configuring the agent with a longer timeout than the proxy server, but since the proxy agent and server might not be run by the same administrator, it is better to make the agent handle this scenario gracefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the agent tries to list pending requests and there are no requests to return, there are two possible behaviors:
For both of these scenarios, the right next steps are the same; the proxy agent should just keep polling for pending requests.
However, previously these were handled differently; in the first case the agent would poll again immediately, whereas the second it would log an error message and then use backoff logic to decide how long to wait until polling again.
This could be handled by simply configuring the agent with a longer timeout than the proxy server, but since the proxy agent and server might not be run by the same administrator, it is better to make the agent handle this scenario gracefully.