[agent] Add a test for the websocket-shim protocol handlers #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gogasca
approved these changes
Dec 17, 2025
Collaborator
|
Test failed. Wait for the goroutine to finish by synchronizing the test’s teardown. One option is to use a sync.WaitGroup or a channel to signal when proxyCmd.Wait() completes and ensure it’s done before the test exits. |
Collaborator
Author
|
@gogasca Thanks for the review! I was unable to reproduce the test failure; even when running the test 1000 times in a row. That being said, adding the defense you suggested is safe, so I went ahead and put it in. Thanks for the suggestion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.