[WIP] Upgrade the go version to 1.24 and upgrade dependencies to latest versions #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinayakumarb
changed the title
ojarjur
requested changes
Apr 22, 2025
| if requestID == "" { | ||
| errorMsg := "No request ID specified" | ||
| log.Printf(errorMsg) | ||
| log.Println(errorMsg) |
Collaborator
There was a problem hiding this comment.
I'm not aware of any Golang best practices/guidance around not using the *Printf methods for literal strings.
At the very least, however, if we were to make this change then it should be a separate, isolated PR
| module github.com/google/inverting-proxy | ||
|
|
||
| go 1.18 | ||
| go 1.24.2 |
Collaborator
There was a problem hiding this comment.
I'm not aware of a good reason to change this.
This isn't specifying what version of Go you use to build the packages; that's something controlled by the build environment and commands you use.
Instead, this is the minimum version required.
So, changing this is basically saying: "Force the build to fail if someone has anything other than the latest version of Golang installed", and that's a really heavy handed thing to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.