Skip to content

Clarify HostSpecifier URI parser compatibility #8459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bg0d-droid wants to merge 1 commit into from
+14 −0
Closed

Clarify HostSpecifier URI parser compatibility #8459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions android/guava/src/com/google/common/net/HostSpecifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,13 @@
* URI, the domain name case is further restricted to include only those domain names which end in a
* recognized public suffix; see {@link InternetDomainName#isPublicSuffix()} for details.
*
* <p>In this context, "URI" is used in the general sense, and {@code HostSpecifier} does not
* guarantee that every URI or URL parser will accept the original input without additional
* normalization. {@code HostSpecifier} follows the syntactic rules of {@link InetAddresses} and
* {@link InternetDomainName}, including their documented acceptance of some inputs that particular
* URI implementations may reject, such as non-ASCII digits, non-ASCII domain names, or domain
* labels containing underscores.
*
* <p>Note that no network lookups are performed by any {@code HostSpecifier} methods. No attempt is
* made to verify that a provided specifier corresponds to a real or accessible host. Only syntactic
* and pattern-based checks are performed.
Expand Down
7 changes: 7 additions & 0 deletions guava/src/com/google/common/net/HostSpecifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,13 @@
* URI, the domain name case is further restricted to include only those domain names which end in a
* recognized public suffix; see {@link InternetDomainName#isPublicSuffix()} for details.
*
* <p>In this context, "URI" is used in the general sense, and {@code HostSpecifier} does not
* guarantee that every URI or URL parser will accept the original input without additional
* normalization. {@code HostSpecifier} follows the syntactic rules of {@link InetAddresses} and
* {@link InternetDomainName}, including their documented acceptance of some inputs that particular
* URI implementations may reject, such as non-ASCII digits, non-ASCII domain names, or domain
* labels containing underscores.
*
* <p>Note that no network lookups are performed by any {@code HostSpecifier} methods. No attempt is
* made to verify that a provided specifier corresponds to a real or accessible host. Only syntactic
* and pattern-based checks are performed.
Expand Down