Add rewrite support for UnnecessaryParentheses#7934
Closed
Pankraz76 wants to merge 1 commit intogoogle:masterfrom
Closed
Add rewrite support for UnnecessaryParentheses#7934Pankraz76 wants to merge 1 commit intogoogle:masterfrom
rewrite support for UnnecessaryParentheses#7934Pankraz76 wants to merge 1 commit intogoogle:masterfrom
Conversation
Member
|
I am fairly confident that we won't want this check on. We may still be able to take part of #7930, but even it is proving more controversial. (Yes, I take the point that it's nice to have rules for things precisely to avoid controversy :) But a concern is that some ternaries become harder to read for some people without parentheses, and people generally aren't so eager to remove the parentheses that we end up with actual controversy during cod review.) Anyway, I'll follow up on #7930 once I hear more from the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opt in ability plugin to complete:
UnnecessaryParentheses#7930