Fix unable to reopen camera after cancelling picture #3427
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to complete a photo task, if a user cancels taking the picture and tries to re-open the camera again nothing happens. This is because
PhotoTaskViewModel.onCaptureResultwas never settinghasLaunchedCameraas false if there was no picture captured, so the app didn't open a new camera intent since the logic determined it was still open. This is incorrect because whenonCaptureResultis triggered, it means that the camera is not being used anymore.This PR applies a small fix by setting
hasLaunchedCameraas false regardless of theonCaptureResultvalue. This was also tested in an emulator to make sure it's properly fixed and without introducing new issues@shobhitagarwal1612 PTAL?