Skip to content

Completed test in OfflineAreSelectorFragmentTest #3422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anandwana001 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Completed test in OfflineAreSelectorFragmentTest #3422

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
69e4948
completed test
anandwana001 Dec 24, 2025
24732bd
removed todo
anandwana001 Dec 24, 2025
3f3fc29
Merge branch 'master' into anandwana001/3032/complete-offline-test
anandwana001 Dec 27, 2025
cba6d3c
Merge branch 'master' into anandwana001/3032/complete-offline-test
anandwana001 Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions ...va/org/groundplatform/android/ui/offlineareas/selector/OfflineAreaSelectorFragmentTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,23 @@ import androidx.test.espresso.matcher.ViewMatchers.isDisplayed
import androidx.test.espresso.matcher.ViewMatchers.isEnabled
import androidx.test.espresso.matcher.ViewMatchers.withId
import androidx.test.espresso.matcher.ViewMatchers.withText
import dagger.hilt.android.testing.BindValue
import dagger.hilt.android.testing.HiltAndroidTest
import javax.inject.Inject
import junit.framework.Assert.assertFalse
import kotlin.jvm.JvmField
import kotlinx.coroutines.flow.MutableSharedFlow
import kotlinx.coroutines.test.advanceUntilIdle
import org.groundplatform.android.BaseHiltTest
import org.groundplatform.android.R
import org.groundplatform.android.data.local.LocalValueStore
import org.groundplatform.android.launchFragmentInHiltContainer
import org.groundplatform.android.model.geometry.Coordinates
import org.groundplatform.android.model.map.CameraPosition
import org.groundplatform.android.repository.OfflineAreaRepository
import org.groundplatform.android.repository.SurveyRepository
import org.groundplatform.android.repository.UserRepository
import org.groundplatform.android.system.NetworkManager
import org.junit.Assert.assertNull
import org.junit.Before
import org.junit.Rule
Expand All @@ -55,7 +63,11 @@ class OfflineAreaSelectorFragmentTest : BaseHiltTest() {
lateinit var fragment: OfflineAreaSelectorFragment
@Inject lateinit var viewModel: OfflineAreaSelectorViewModel

private val offlineAreaRepository: OfflineAreaRepository = mock()
@BindValue @JvmField val offlineAreaRepository: OfflineAreaRepository = mock()
@BindValue @JvmField val surveyRepository: SurveyRepository = mock()
@BindValue @JvmField val networkManager: NetworkManager = mock()
@BindValue @JvmField val userRepository: UserRepository = mock()
@BindValue @JvmField val localValueStore: LocalValueStore = mock()

@get:Rule override val composeTestRule = createAndroidComposeRule<ComponentActivity>()

Expand Down Expand Up @@ -87,11 +99,18 @@ class OfflineAreaSelectorFragmentTest : BaseHiltTest() {
)
}

// TODO: Complete below test
// Issue URL: https://github.com/google/ground-android/issues/3032
@Test
fun `stopDownloading cancels active download and updates UI state`() = runWithTestDispatcher {
composeTestRule.setContent { DownloadProgressDialog(viewModel.downloadProgress.value!!, {}) }
whenever(networkManager.isNetworkConnected()).thenReturn(true)
// Set camera position to ensure viewport is valid and zoom level is sufficient for download
viewModel.onMapCameraMoved(CameraPosition(Coordinates(0.0, 0.0), zoomLevel = 10.0f))

composeTestRule.setContent {
DownloadProgressDialog(
progress = viewModel.downloadProgress.value!!,
onDismiss = { viewModel.stopDownloading() },
)
}
Comment on lines +108 to +113
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be getting triggered via the actual code?


val progressFlow = MutableSharedFlow<Pair<Int, Int>>()
whenever(offlineAreaRepository.downloadTiles(any())).thenReturn(progressFlow)
Expand All @@ -104,6 +123,15 @@ class OfflineAreaSelectorFragmentTest : BaseHiltTest() {
viewModel.onDownloadClick()
advanceUntilIdle()

// Verify progress visibility is true after download starts
composeTestRule
.onNodeWithText(
composeTestRule.activity.getString(
R.string.offline_map_imagery_download_progress_dialog_message
)
)
.isDisplayed()

progressFlow.emit(Pair(50, 100))
advanceUntilIdle()

Expand Down