chore: Simplify generate.sh by removing git worktree and using generator-based check #4120
Merged
gmlewis merged 6 commits intogoogle:masterfrom Mar 26, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4120 +/- ##
=======================================
Coverage 93.71% 93.71%
=======================================
Files 211 211
Lines 19614 19614
=======================================
Hits 18382 18382
Misses 1034 1034
Partials 198 198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexandear
reviewed
Mar 25, 2026
alexandear
reviewed
Mar 25, 2026
gmlewis
requested changes
Mar 26, 2026
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @Not-Dhananjay-Mishra and @alexandear!
Just a few minor tweaks, please, then we can merge.
gmlewis
changed the title
generate.sh by removing git worktree and using generator-based check generate.sh by removing git worktree and using generator-based check
gmlewis
approved these changes
Mar 26, 2026
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @Not-Dhananjay-Mishra!
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
-check(env-driven viaCHECK=1) support to:Simplified script/generate.sh to:
go generate ./...CHECK=1Related : #3983