Allow multiple boot attempts in event log extraction.#24
Merged
jkl73 merged 4 commits intogoogle:mainfrom Feb 25, 2026
Merged
Conversation
This change introduces support for the "Returning from EFI Application from Boot Option" event, which indicates a failed boot attempt. Seeing this event resets the state, allowing for subsequent "Calling EFI Application from Boot Option" events. This is necessary for hardware that may attempt to boot from multiple devices. Additionally, a separator event is now required to be preceded by at least one "Calling EFI Application" event. Referenced from Section 10.4.4 EV_EFI_ACTION Event Types from TCG doc- https://trustedcomputinggroup.org/wp-content/uploads/TCG-PC-Client-PFP-Version-1.06-Revision-49_31July2023.pdf
alexmwu
reviewed
Feb 19, 2026
Collaborator
alexmwu
left a comment
alexmwu
left a comment
There was a problem hiding this comment.
This PR needs an example CCEL and happy path/failure tests running against it that.
…DX RTMR and TPM PCR.
Contributor
Author
Updated. |
jkl73
reviewed
Feb 24, 2026
jkl73
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces support for the "Returning from EFI Application from Boot Option" event, which indicates a failed boot attempt. Seeing this event resets the state, allowing for subsequent "Calling EFI Application from Boot Option" events. This is necessary for hardware that may attempt to boot from multiple devices.
A separator event is now required to be preceded by at least one "Calling EFI Application" event. In case boot attempt events are omitted (EV_OMIT_BOOT_DEVICE_EVENTS) by firmware, then the library would throw an error of seeing a separator event without a calling EFI app event, but prioritizing support of multiple boot attempts over device events omission.
Referenced from Section 10.4.4 EV_EFI_ACTION Event Types from TCG doc- https://trustedcomputinggroup.org/wp-content/uploads/TCG-PC-Client-PFP-Version-1.06-Revision-49_31July2023.pdf