Open
Conversation
Using the lib in embedded environments, causes issues with compilation using ARM embedded toolchains. The call to round() is being resolved as a call to lround() and hence breaks the build, as std::max() expects two arguments of type double. Making it a explicit call to std::round() fixes the issue.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
这是来自QQ邮箱的假期自动回复邮件。你好,我最近正在休假中,无法亲自回复你的邮件。我将在假期结束后,尽快给你回复。
|
Author
|
Well, I don't want to go through all that formalities (I don't have nor want to have a google account) just to submit such a miniscule change, perhaps it's better if I submit it via issue tracking system.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the lib in embedded environments, causes issues with compilation using ARM embedded toolchains. The call to round() is being resolved as a call to lround() and hence breaks the build, as std::max() expects two arguments of type double. Making it a explicit call to std::round() fixes the issue.