Improve robustness and fix execution hang in scripts/run_multimodal.py#89
Open
CodersAcademy006 wants to merge 1 commit intogoogle:mainfrom
Open
Improve robustness and fix execution hang in scripts/run_multimodal.py#89CodersAcademy006 wants to merge 1 commit intogoogle:mainfrom
CodersAcademy006 wants to merge 1 commit intogoogle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #88
This PR introduces two key improvements to
scripts/run_multimodal.pyto enhance its robustness and fix a critical execution bug in non-interactive environments.1. Fix Execution Hang in Docker
image.show()call from the image loading loop.2. Refactor for Robust Weight Loading
torch.loadandmodel.load_state_dictcall with the recommendedmodel.load_weights()helper method.load_weightsmethod is designed to handle both single-file and sharded checkpoints automatically, improving maintainability.Overall, these changes make the script more reliable and easier to use in its primary documented environments.