Open
Conversation
Author
|
@pengchongjin any idea for this? |
Contributor
|
Thanks for the change. Could you please paste a few example outputs before and after this change? Also please make sure to test both run.py and run_xla.py. Thanks! |
Author
|
@pengchongjin model generates token regardless of eos token, so time spent in generation increases quadratically as output_len increases model stop generate when model samples out eos token time spent in generation remain still as output_len increases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


With model.generate() it takes too long even sequence generation have done earlier with EOS token. Because now, it generates til it reached to output_len
fix the generate method to stop when every sequence has generated EOS token