Skip to content

fix: add null check for file_saver in GenerateBinary to prevent null dereference #9161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
freinkxhihani-a11y wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −0
Open

fix: add null check for file_saver in GenerateBinary to prevent null dereference #9161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/idl_gen_binary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ static std::string BinaryFileName(const Parser& parser, const std::string& path,

static bool GenerateBinary(const Parser& parser, const std::string& path,
const std::string& file_name) {
if (!parser.opts.file_saver) return false;
if (parser.opts.use_flexbuffers) {
auto data_vec = parser.flex_builder_.GetBuffer();
auto data_ptr = reinterpret_cast<char*>(data(data_vec));
Expand Down