Skip to content

Fix heap OOB write in ForAllFields when field ID exceeds field count #9054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohamedelabbas1996 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix heap OOB write in ForAllFields when field ID exceeds field count #9054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/reflection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,11 @@ void ForAllFields(const reflection::Object* object, bool reverse,
// Create the mapping of field ID to the index into the vector.
for (uint32_t i = 0; i < object->fields()->size(); ++i) {
auto field = object->fields()->Get(i);
field_to_id_map[field->id()] = i;
// Validate field ID to prevent out-of-bounds write when processing
// untrusted binary schemas (.bfbs files).
if (field->id() < object->fields()->size()) {
field_to_id_map[field->id()] = i;
}
}

for (size_t i = 0; i < field_to_id_map.size(); ++i) {
Expand Down