Skip to content

Fix INDEPENDENT mechanism crash on duplicate cliques #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gghatano wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

Fix INDEPENDENT mechanism crash on duplicate cliques #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion dpsynth/discrete_mechanisms/independent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,13 @@ def run_mechanism(

potentials = initial_potentials
if potentials is not None:
potentials = potentials.expand([m.clique for m in measurements])
# `measurements` can contain the same clique more than once (the one-way

@ryan112358 ryan112358 Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the bug fix, but can you remove this inline comment or reduce it to 1 line?

@ryan112358 ryan112358 Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add test coverage for this case?

# marginals passed in via `initial_measurements` plus the one-way marginals
# measured in the loop above). `CliqueVector.expand` requires unique cliques
# and otherwise raises "Cliques must be unique.", so de-duplicate while
# preserving order before expanding.
unique_cliques = list(dict.fromkeys(m.clique for m in measurements))
potentials = potentials.expand(unique_cliques)

model = mbi.estimation.mirror_descent(
data.domain,
Expand Down
Loading