[github_pr_destination] Don't require context reference if pr_branch is set#229
Open
restingbull wants to merge 2 commits intogoogle:masterfrom
Open
[github_pr_destination] Don't require context reference if pr_branch is set#229restingbull wants to merge 2 commits intogoogle:masterfrom
pr_branch is set#229restingbull wants to merge 2 commits intogoogle:masterfrom
Conversation
…` is set
This will allow copybara to succeed for the following origin:
```
git.origin(
url = "https://github.com/google/copybara.git",
ref = "b0f6c6bbb5828c95b2b1409b4e491865d969f679",
)
```
* This appears to be a reasonable compromise given that there are many ways to create a Revision without context reference. * Add null handling for Revision in pr branch name resolution (as it's marked with Nullable, however *that* works.) * Fail when labels other than CONTEXT_REFERENCE are used in the pr name. (bit of a bug -- previously, for any interpolated label would just reprint the label. Since no tests failed when fixed, it appears to be unexpected behaviour.) * Side note: these files seem to have missed the goggle-java-format boat. :[
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forked from #226 to address requested changes.
This will allow copybara to succeed for the following origin:
Changes
Only fail on missing context reference when it is required.
cc: @Yannic, @petemounce