Skip to content

feat: add cpu burst metrics #3795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dims merged 1 commit into from
Dec 18, 2025
Merged

feat: add cpu burst metrics #3795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions container/libcontainer/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,6 +771,8 @@ func setCPUStats(s *cgroups.Stats, ret *info.ContainerStats, withPerCPU bool) {
ret.Cpu.CFS.Periods = s.CpuStats.ThrottlingData.Periods
ret.Cpu.CFS.ThrottledPeriods = s.CpuStats.ThrottlingData.ThrottledPeriods
ret.Cpu.CFS.ThrottledTime = s.CpuStats.ThrottlingData.ThrottledTime
ret.Cpu.CFS.BurstsPeriods = s.CpuStats.BurstData.BurstsPeriods
ret.Cpu.CFS.BurstTime = s.CpuStats.BurstData.BurstTime
setPSIStats(s.CpuStats.PSI, &ret.Cpu.PSI)

if !withPerCPU {
Expand Down
7 changes: 7 additions & 0 deletions info/v1/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,13 @@ type CpuCFS struct {
// Total time duration for which tasks in the cgroup have been throttled.
// Unit: nanoseconds.
ThrottledTime uint64 `json:"throttled_time"`

// Total number of periods when CPU burst occurs.
BurstsPeriods uint64 `json:"bursts_periods"`

// Total time duration when CPU burst occurs.
// Unit: nanoseconds.
BurstTime uint64 `json:"burst_time"`
}

// Cpu Aggregated scheduler statistics
Expand Down
24 changes: 24 additions & 0 deletions metrics/prometheus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,30 @@ func NewPrometheusCollector(i infoProvider, f ContainerLabelsFunc, includedMetri
timestamp: s.Timestamp,
}}
},
}, {
name: "container_cpu_cfs_burst_periods_total",
help: "Number of periods when burst occurs.",
valueType: prometheus.CounterValue,
condition: func(s info.ContainerSpec) bool { return s.Cpu.Quota != 0 },
getValues: func(s *info.ContainerStats) metricValues {
return metricValues{
{
value: float64(s.Cpu.CFS.BurstsPeriods),
timestamp: s.Timestamp,
}}
},
}, {
name: "container_cpu_cfs_burst_seconds_total",
help: "Total time duration the container has been bursted.",
valueType: prometheus.CounterValue,
condition: func(s info.ContainerSpec) bool { return s.Cpu.Quota != 0 },
getValues: func(s *info.ContainerStats) metricValues {
return metricValues{
{
value: float64(s.Cpu.CFS.BurstTime) / float64(time.Second),
timestamp: s.Timestamp,
}}
},
},
}...)
}
Expand Down
2 changes: 2 additions & 0 deletions metrics/prometheus_fake.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,8 @@ func (p testSubcontainersInfoProvider) GetRequestedContainersInfo(string, v2.Req
Periods: 723,
ThrottledPeriods: 18,
ThrottledTime: 1724314000,
BurstsPeriods: 25,
BurstTime: 500000000,
},
Schedstat: info.CpuSchedstat{
RunTime: 53643567,
Expand Down
36 changes: 36 additions & 0 deletions metrics/prometheus_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,3 +428,39 @@ func TestIOCostMetrics(t *testing.T) {
})
}
}

func TestCPUBurstMetrics(t *testing.T) {
containerStats := &info.ContainerStats{
Timestamp: time.Unix(1395066363, 0),
Cpu: info.CpuStats{
CFS: info.CpuCFS{
BurstsPeriods: 25,
BurstTime: 500000000,
},
},
}

testCases := []struct {
name string
getValue func() float64
expectedValue float64
}{
{
name: "BurstsPeriods",
getValue: func() float64 { return float64(containerStats.Cpu.CFS.BurstsPeriods) },
expectedValue: 25.0,
},
{
name: "BurstTime",
getValue: func() float64 { return float64(containerStats.Cpu.CFS.BurstTime) / float64(time.Second) },
expectedValue: 0.5,
},
}

for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
result := tc.getValue()
assert.Equal(t, tc.expectedValue, result)
})
}
}
6 changes: 6 additions & 0 deletions metrics/testdata/prometheus_metrics
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ container_cpu_cfs_throttled_periods_total{container_env_foo_env="prod",container
# HELP container_cpu_cfs_throttled_seconds_total Total time duration the container has been throttled.
# TYPE container_cpu_cfs_throttled_seconds_total counter
container_cpu_cfs_throttled_seconds_total{container_env_foo_env="prod",container_label_foo_label="bar",id="testcontainer",image="test",name="testcontaineralias",zone_name="hello"} 1.724314 1395066363000
# HELP container_cpu_cfs_burst_periods_total Number of periods when burst occurs.
# TYPE container_cpu_cfs_burst_periods_total counter
container_cpu_cfs_burst_periods_total{container_env_foo_env="prod",container_label_foo_label="bar",id="testcontainer",image="test",name="testcontaineralias",zone_name="hello"} 25 1395066363000
# HELP container_cpu_cfs_burst_seconds_total Total time duration the container has been bursted.
# TYPE container_cpu_cfs_burst_seconds_total counter
container_cpu_cfs_burst_seconds_total{container_env_foo_env="prod",container_label_foo_label="bar",id="testcontainer",image="test",name="testcontaineralias",zone_name="hello"} 0.5 1395066363000
# HELP container_cpu_load_average_10s Value of container cpu load average over the last 10 seconds.
# TYPE container_cpu_load_average_10s gauge
container_cpu_load_average_10s{container_env_foo_env="prod",container_label_foo_label="bar",id="testcontainer",image="test",name="testcontaineralias",zone_name="hello"} 2 1395066363000
Expand Down
6 changes: 6 additions & 0 deletions metrics/testdata/prometheus_metrics_whitelist_filtered
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ container_cpu_cfs_throttled_periods_total{container_env_foo_env="prod",id="testc
# HELP container_cpu_cfs_throttled_seconds_total Total time duration the container has been throttled.
# TYPE container_cpu_cfs_throttled_seconds_total counter
container_cpu_cfs_throttled_seconds_total{container_env_foo_env="prod",id="testcontainer",image="test",name="testcontaineralias",zone_name="hello"} 1.724314 1395066363000
# HELP container_cpu_cfs_burst_periods_total Number of periods when burst occurs.
# TYPE container_cpu_cfs_burst_periods_total counter
container_cpu_cfs_burst_periods_total{container_env_foo_env="prod",id="testcontainer",image="test",name="testcontaineralias",zone_name="hello"} 25 1395066363000
# HELP container_cpu_cfs_burst_seconds_total Total time duration the container has been bursted.
# TYPE container_cpu_cfs_burst_seconds_total counter
container_cpu_cfs_burst_seconds_total{container_env_foo_env="prod",id="testcontainer",image="test",name="testcontaineralias",zone_name="hello"} 0.5 1395066363000
# HELP container_cpu_load_average_10s Value of container cpu load average over the last 10 seconds.
# TYPE container_cpu_load_average_10s gauge
container_cpu_load_average_10s{container_env_foo_env="prod",id="testcontainer",image="test",name="testcontaineralias",zone_name="hello"} 2 1395066363000
Expand Down
Loading