fix: modified container healthcheck to support custom port via -port/--port flag #3789
+71
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
The Dockerfile currently has a static healthcheck URL (http://localhost:8080/healthz) that doesn't adapt when users specify a different port using the -port flag. This causes healthchecks to fail when running cAdvisor on non-default ports.
Related Issues
Fixes #3618
Root Cause
Environment variables set in the entrypoint script don't persist for HEALTHCHECK commands because they run in separate process contexts. Docker doesn't share the entrypoint's environment with the healthcheck process.
Proposed Solution
Implemented a dedicated healthcheck script that:
/proc/1/cmdline-portflag to extract the actual portThis approach works because Docker healthchecks run inside the container and can access the process information.
Breaking Changes
None - fully backward compatible
Test Case 1: Default Port (8080)
Test Case 2: Custom Port (9090)
Test Case 3: Verify Healthcheck Logic
Note:
Individual CLA submitted