Skip to content

Conversation

@thaJeztah
Copy link
Contributor

relates to #3761 (comment)

Attempt to adjust the tests to work with a docker daemon using the containerd snapshotters (which would have, e.g., "overlayfs" instead of "overlay2" as storage driver).

@thaJeztah
Copy link
Contributor Author

haven't tested locally, so (ab)using CI to see if it passes, but looks like it needs approval again @dims 🙈 (is there some way around that, or is it for all contributors ?)

@dims
Copy link
Collaborator

dims commented Dec 5, 2025

i am here for you @thaJeztah :)

(not a GOOG employee, so am a guest here! can't fiddle with things)

@dims
Copy link
Collaborator

dims commented Dec 5, 2025

@thaJeztah
Copy link
Contributor Author

Thank you! Yes, these are a bit of a nuisance; debugging CI usually is a bit of trial-and-error, and I'm not very familiar with the codebase, so that makes it extra fun.

OK got some other failures. Maybe I should look if I can run these tests locally somewhere; of course don't let me stop others from digging in as well! (for anyone stumbling on this PR).

@thaJeztah for now please rebase your other PR, we pinned the SHA of the image:

oh, thanks, will do!

@dims
Copy link
Collaborator

dims commented Dec 16, 2025

@thaJeztah can you please revert the change we made here:
https://github.com/google/cadvisor/pull/3760/changes#diff-cd7456ced655187a04317519eb6843c67536f406233cf66105c2d9cfc592d96dR61

and see if this still works?

Attempt to adjust the tests to work with a docker daemon using the
containerd snapshotters (which would have, e.g., "overlayfs" instead of
"overlay2" as storage driver).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…ging-test-infra/bootstrap"

This reverts commit a310a2c.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Contributor Author

done! added a commit to revert it; let's see what breaks 😅 (ISTR things weren't happy before that, so possibly more changes are needed)

@dims
Copy link
Collaborator

dims commented Dec 17, 2025

interesting failure

=== RUN   TestDockerContainerSpec
I1217 13:29:10.867374     550 framework.go:370] About to run - [sudo docker run -d --cpu-shares 2048 --cpuset-cpus 0 --memory 1073741824 --env TEST_VAR=FOO --label bar=baz registry.k8s.io/pause]
    docker_test.go:224: 
I1217 13:29:10.998661     550 framework.go:370] About to run - [sudo docker rm -f 4df5979058f4b930aa09c193e4755275eb41c333dee377f3808a5b50e1b1e485]
        	Error Trace:	/go/src/github.com/google/cadvisor/integration/tests/api/docker_test.go:224
        	Error:      	Not equal: 
        	            	expected: 0x7fe
        	            	actual  : 0x11b9
        	Test:       	TestDockerContainerSpec
        	Messages:   	Container should have 2046 shares, has 4537
--- FAIL: TestDockerContainerSpec (0.21s)

@thaJeztah
Copy link
Contributor Author

Wondering if it's related to;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants