Skip to content

Don't report error.NonExistentClass types as validation errors #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 3, 2026
+11 −0
Merged

Don't report error.NonExistentClass types as validation errors #2083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/src/main/java/com/google/auto/common/SuperficialValidation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
*/
package com.google.auto.common;

import static com.google.auto.common.MoreTypes.asTypeElement;

import java.util.List;
import java.util.Map;
import java.util.stream.StreamSupport;
Expand Down Expand Up @@ -148,6 +150,15 @@ public Boolean visitDeclared(DeclaredType t, Void p) {

@Override
public Boolean visitError(ErrorType t, Void p) {
if (asTypeElement(t).getQualifiedName().contentEquals("error.NonExistentClass")) {
// See
// https://youtrack.jetbrains.com/issue/KT-34193/Kapt-CorrectErrorTypes-doesnt-work-for-generics
// KAPT will generate stubs referencing 'error.NonExistentClass' even when
// 'correctErrorTypes=true' is enabled. Thus, we can't treat 'error.NonExistentClass' as
// an actual error type, as that would completely prevent processing of stubs that
// exhibit this bug.
return true;
}
return false;
}

Expand Down
Loading