Use a quasi-unique group name in this e2e test.#1983
Use a quasi-unique group name in this e2e test.#19833405691582 wants to merge 1 commit intogoogle:mainfrom
Conversation
I suspect there may be either some lack of cleanup or race that occurs when executing the tests, since the error mentions "An instance group already exists with name: cvd". I don't want to plumb too deeply into figuring out exactly why this happens; instead, just generate a quasi-unique group name based on the time and this way they should likely not collide any more.
There was a problem hiding this comment.
Let's fail if there's a cvd instance already created when the tests is about to run. The e2e test creating instances were implemented to be run in clean containers https://github.com/google/android-cuttlefish/blob/main/.github/actions/run-cw-sharded-e2e-test/action.yaml#L72 each of them.
|
Explaining the group name collision error: When |
|
Different approach taken elsewhere. |
I suspect there may be either some lack of cleanup or race that occurs when executing the tests, since the error mentions "An instance group already exists with name: cvd". I don't want to plumb too deeply into figuring out exactly why this happens; instead, just generate a quasi-unique group name based on the time and this way they should likely not collide any more.