Port virtio media simple device as a vhost user media device.#1895
Merged
ser-io merged 1 commit intogoogle:mainfrom Mar 5, 2026
Merged
Port virtio media simple device as a vhost user media device.#1895ser-io merged 1 commit intogoogle:mainfrom
ser-io merged 1 commit intogoogle:mainfrom
Conversation
Member
Why are you copying this code here instead of depending on it? Would it be possible to contribute changes upstream and only implement the cuttlefish-specific changes here? |
jemoreira
reviewed
Dec 16, 2025
Databean
reviewed
Dec 16, 2025
ser-io
force-pushed
the
virtio-media-use-new-SHMEM
branch
from
d42f8bd to
db5b139
Compare
Member
Author
Removed the copy depending on the upstream implementation. |
ser-io
force-pushed
the
virtio-media-use-new-SHMEM
branch
3 times, most recently
from
833efed to
fadcf29
Compare
ser-io
commented
Jan 24, 2026
ser-io
force-pushed
the
virtio-media-use-new-SHMEM
branch
from
fadcf29 to
8b2a123
Compare
jemoreira
approved these changes
Jan 24, 2026
ser-io
force-pushed
the
virtio-media-use-new-SHMEM
branch
from
8b2a123 to
774f02d
Compare
Databean
reviewed
Jan 29, 2026
Databean
reviewed
Jan 29, 2026
Member
Databean
left a comment
Databean
left a comment
There was a problem hiding this comment.
Some of the comments apply in multiple places, like reducing map_err usage in favor of automatic conversion with From.
ser-io
force-pushed
the
virtio-media-use-new-SHMEM
branch
6 times, most recently
from
cdc74cb to
61f4245
Compare
ser-io
force-pushed
the
virtio-media-use-new-SHMEM
branch
from
61f4245 to
9771f15
Compare
Databean
approved these changes
Feb 27, 2026
Run the device. ``` RUST_LOG=trace cargo run --bin simple_device -- --socket-path /tmp/simple_device.sock or RUST_LOG=trace bazel run simple_device:simple_device -- --socket-path /tmp/simple_device.sock ``` Run the VM. ``` cargo run -- --log-level=debug run --cpus 4 --mem 4096 \ --rwdisk /path/to/debian-12.img \ --params "root=/dev/vda1" \ --vhost-user media,socket=/tmp/simple_device.sock \ /path/to/bzImage v4l2-compliance -d0 -s ``` Bug: 445229097
ser-io
force-pushed
the
virtio-media-use-new-SHMEM
branch
from
9771f15 to
6d56a54
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port virtio media reference device
simple_deviceas a vhost user implementation.First iteration of
simple_device/src/simple_device.rsis the same as in virtio-media upstream https://github.com/chromeos/virtio-media/blob/main/device/src/devices/simple_device.rs.Bug: 445229097