security: fix RCE vulnerability in test_templated_agent workflow#1945
Open
enriquekalven wants to merge 2 commits into
Open
security: fix RCE vulnerability in test_templated_agent workflow#1945enriquekalven wants to merge 2 commits into
enriquekalven wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution
Revert Trigger: Switched the workflow trigger from pull_request_target back to a standard pull_request trigger.
Secure Checkout: Removed all ref: ${{ github.event.pull_request.head.sha }} inputs from the actions/checkout actions.
By switching to pull_request, any code checked out from external forks will run in a restricted runner sandbox with no access to the base repository's secrets or high-privilege OIDC identity federation. This prevents any malicious changes from accessing sensitive project resources.
Verification & Testing
Validated the syntax of the modified workflow file .github/workflows/test_templated_agent.yaml using a YAML parser.
Verified that no other workflows in .github/workflows/ combine pull_request_target with checking out untrusted head SHAs.