Add starter pack to google trends agent#1028
Conversation
…te uv lock file, add flexible authentication block
|
Please address the formatting issues (ruff, lint) before I review the PR. |
d370e88 to
b9ebbb0
Compare
|
I see there are two folders in this PR:
However, other than an |
2672bba to
5401e86
Compare
zeroasterisk
left a comment
There was a problem hiding this comment.
ASP Integration Checklist (ref: PR #1286 as approved template)
- ✅ Auth block with
google.auth.default()+os.environ.setdefault— correct - ✅ ASP section present in README
⚠️ ASP listed as "Alternative" — Should be the recommended path. Flip: ASP withuvxone-liner first as the primary visible command, then collapse manual setup in<details>. See #1286 for the exact pattern.⚠️ uvxis collapsed, pip is primary — Backwards.uvxone-liner should be the main command, pip/venv in a collapsed<details>block.
Same fix needed across all your ASP PRs — flip ASP to recommended, uvx as primary. Use #1286 as the reference template.
123e098 to
1071c2a
Compare
zeroasterisk
left a comment
There was a problem hiding this comment.
LGTM — ASP as recommended, uvx primary, setdefault correct. ✅
zeroasterisk
left a comment
There was a problem hiding this comment.
A few things to fix:
- Import order in
__init__.py:from . import agentmust come AFTER thegoogle.auth.default()+os.environ.setdefault(...)block. The agent module reads env vars at import time, so auth needs to run first. Add# noqa: E402to the moved import line. - Bump
agent-starter-packto>=0.32.0(currently>=0.14.1) - Regenerate
uv.lock— runuv lockafter updating dependencies - Add Apache 2.0 license header to
__init__.py(see other samples for the template)
See PR #1226 (academic-research) for a good reference of the correct pattern.
…=0.32.0, add Apache 2.0 license header
zeroasterisk
left a comment
There was a problem hiding this comment.
Changes look great, thank you! ✅


TESTING

@eliasecchig