Skip to content

Add starter pack to google trends agent#1028

Merged
zeroasterisk merged 15 commits intogoogle:mainfrom
tristanhussain:feat/gta-add-starter-pack
Apr 8, 2026
Merged

Add starter pack to google trends agent#1028
zeroasterisk merged 15 commits intogoogle:mainfrom
tristanhussain:feat/gta-add-starter-pack

Conversation

@tristanhussain
Copy link
Copy Markdown
Contributor

@tristanhussain tristanhussain commented Feb 7, 2026

  • Add Agent Starter Pack metadata to pyproject.toml
  • Add Agent Starter Pack as dev dependency
  • Replace any existing Poetry development setup instructions with uv
  • Update authentication configuration
  • Modify README with starter pack instructions

TESTING
image

@eliasecchig

@happyhuman
Copy link
Copy Markdown
Collaborator

Please address the formatting issues (ruff, lint) before I review the PR.

@tristanhussain tristanhussain force-pushed the feat/gta-add-starter-pack branch from d370e88 to b9ebbb0 Compare February 11, 2026 18:22
@tristanhussain
Copy link
Copy Markdown
Contributor Author

Please address the formatting issues (ruff, lint) before I review the PR.

image

@happyhuman
Copy link
Copy Markdown
Collaborator

I see there are two folders in this PR:

  • google-trends-agent
  • parallel_task_decomposition_execution

However, other than an __init__.py file, neither folder has any code in it. So, they do not contain any real agent code.
Please do the following:
1- Submit one agent per PR
2- Make sure they contain the actual code
3- Make sure the PR checkers all pass (lots of them are currently failing).

@tristanhussain tristanhussain force-pushed the feat/gta-add-starter-pack branch from 2672bba to 5401e86 Compare February 14, 2026 16:34
@tristanhussain
Copy link
Copy Markdown
Contributor Author

Looks like theres a Ruff Format/Lint error in a main.py file in a separate agent \retail-ai-location-strategy.

Should I fix this and add it to this PR? I'm not sure if this will cause any confusion since this PR is for google-trends-agent

image

Copy link
Copy Markdown
Collaborator

@zeroasterisk zeroasterisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASP Integration Checklist (ref: PR #1286 as approved template)

  • ✅ Auth block with google.auth.default() + os.environ.setdefault — correct
  • ✅ ASP section present in README
  • ⚠️ ASP listed as "Alternative" — Should be the recommended path. Flip: ASP with uvx one-liner first as the primary visible command, then collapse manual setup in <details>. See #1286 for the exact pattern.
  • ⚠️ uvx is collapsed, pip is primary — Backwards. uvx one-liner should be the main command, pip/venv in a collapsed <details> block.

Same fix needed across all your ASP PRs — flip ASP to recommended, uvx as primary. Use #1286 as the reference template.

@tristanhussain tristanhussain force-pushed the feat/gta-add-starter-pack branch from 123e098 to 1071c2a Compare March 24, 2026 14:00
Copy link
Copy Markdown
Collaborator

@zeroasterisk zeroasterisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — ASP as recommended, uvx primary, setdefault correct. ✅

@happyhuman happyhuman requested review from tommywagz and removed request for tommywagz March 26, 2026 18:19
Copy link
Copy Markdown
Collaborator

@zeroasterisk zeroasterisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to fix:

  1. Import order in __init__.py: from . import agent must come AFTER the google.auth.default() + os.environ.setdefault(...) block. The agent module reads env vars at import time, so auth needs to run first. Add # noqa: E402 to the moved import line.
  2. Bump agent-starter-pack to >=0.32.0 (currently >=0.14.1)
  3. Regenerate uv.lock — run uv lock after updating dependencies
  4. Add Apache 2.0 license header to __init__.py (see other samples for the template)

See PR #1226 (academic-research) for a good reference of the correct pattern.

Copy link
Copy Markdown
Collaborator

@zeroasterisk zeroasterisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great, thank you! ✅

Copy link
Copy Markdown
Collaborator

@zeroasterisk zeroasterisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(duplicate approval removed)

@zeroasterisk zeroasterisk merged commit 89063ca into google:main Apr 8, 2026
2 checks passed
Copy link
Copy Markdown
Collaborator

@zeroasterisk zeroasterisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(duplicate approval removed)

Copy link
Copy Markdown
Collaborator

@zeroasterisk zeroasterisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(duplicate approval removed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants