test(tools): add coverage for ForwardingArtifactService#6196
Open
nuthalapativarun wants to merge 1 commit into
Open
test(tools): add coverage for ForwardingArtifactService#6196nuthalapativarun wants to merge 1 commit into
nuthalapativarun wants to merge 1 commit into
Conversation
7756ce8 to
732579b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
2. Or, if no issue exists, describe the change:
Problem:
ForwardingArtifactService(used byAgentToolto forward artifact operations from a sub-agent'sToolContextback to the root invocation context) has no unit test coverage. In particular,list_artifact_versionsandget_artifact_versionare unimplemented stubs that raiseNotImplementedError, and the delegation logic insave_artifact,load_artifact,list_artifact_keys,delete_artifact, andlist_versionsis untested.Solution: Add
tests/unittests/tools/test_forwarding_artifact_service.pywith unit tests covering:save_artifact,load_artifact, andlist_artifact_keysto the wrappedToolContext.delete_artifactandlist_versionsto the root invocation context'sartifact_service, including theValueErrorraised when no root artifact service is configured.NotImplementedErrorraised by both unimplemented stubs (list_artifact_versions,get_artifact_version).This is a test-only change with no behavior modifications.
Testing Plan
Unit Tests:
Manual End-to-End (E2E) Tests:
N/A — test-only addition, no runtime behavior change.
Checklist
Additional context
No associated issue — this is a pure test-coverage addition with no behavior change, per CONTRIBUTING.md's allowance for small, focused PRs.