Skip to content

fix(flows): Reset reconnect attempts on connection success#6042

Merged
wukath merged 1 commit into
v1from
fix-v1-live-reconnect-attempt-reset
Jun 10, 2026
Merged

fix(flows): Reset reconnect attempts on connection success#6042
wukath merged 1 commit into
v1from
fix-v1-live-reconnect-attempt-reset

Conversation

@wukath

@wukath wukath commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Reset the reconnect attempt counter immediately when a live connection is established successfully, rather than waiting for the first event to be received. This prevents reconnection failures if the connection succeeds but no events are received before a transient disconnect occurs.

@adk-bot adk-bot added the live [Component] This issue is related to live, voice and video chat label Jun 9, 2026
@adk-bot

adk-bot commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Response from ADK Triaging Agent

Hello @wukath, thank you for contributing to the ADK project and opening this PR!

We noticed that your PR is currently missing a few requirements outlined in our contribution guidelines:

  • Testing Plan: Please include a testing plan section in your PR description to outline how you verified your changes.
  • Logs or Screenshots: Since this is a bug fix, please provide logs or a screenshot after the fix is applied to help reviewers verify and understand the change.

Providing this information will help our maintainers review and merge your PR more efficiently. Thank you!

@wukath wukath force-pushed the fix-v1-live-reconnect-attempt-reset branch 2 times, most recently from a8b774c to e1788b4 Compare June 9, 2026 23:58
Reset the reconnect attempt counter immediately when a live connection is established successfully, rather than waiting for the first event to be received. This prevents reconnection failures if the connection succeeds but no events are received before a transient disconnect occurs.

Change-Id: I9a8002558525fad5715b9a0ac5cf2634a92b923f
@wukath wukath force-pushed the fix-v1-live-reconnect-attempt-reset branch from e1788b4 to 16d496b Compare June 10, 2026 00:02
@wukath wukath requested a review from wuliang229 June 10, 2026 00:08
@wukath wukath merged commit 87abf23 into v1 Jun 10, 2026
14 checks passed
@wuliang229 wuliang229 deleted the fix-v1-live-reconnect-attempt-reset branch June 17, 2026 19:56
@wissamblue69-dotcom

Copy link
Copy Markdown

Reset the reconnect attempt counter immediately when a live connection is established successfully, rather than waiting for the first event to be received. This prevents reconnection failures if the connection succeeds but no events are received before a transient disconnect occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

live [Component] This issue is related to live, voice and video chat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants